-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multilevel navigation #512
Conversation
PageTagNavigationViewsDictionary , PageIdNavigationViewsDictionary , PageTypeNavigationViewsDictionary
…aderContent property
@pomianowski how about not adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the huge amount of work you put into improving the navigation. Looks much better now. Breadcrumb for sub-items and styles can still be improved, but for now it looks great.
@@ -91,6 +91,7 @@ public MainWindowViewModel(IServiceProvider serviceProvider) | |||
{ | |||
new NavigationViewItem { Content = "BreadcrumbBar", TargetPageType = typeof(BreadcrumbBarPage) }, | |||
new NavigationViewItem { Content = "NavigationView", TargetPageType = typeof(NavigationViewPage) }, | |||
new NavigationViewItem { Content = "Multilevel navigation demo", TargetPageType = typeof(MultilevelNavigationPage) }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda long title, maybe just "Multilevel navigation"
There are a few bugs left to fix in Wpf.Ui.Demo |
How about to review a #502 ? |
Cleans and simplified
NavigationView
code.Removed multiple enumerations over
MenuItems
andFooterMenuItems
.Pull request type
What is the new behavior?
BreadcrumbBar
NavigateWithHierarchy
Navigating
event that supports canceling the current navigationGoBack
Other information
GoForward
currently is not implemented