Image Control #517
Merged
Image Control #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
pomianowski
reviewed
Feb 3, 2023
| @@ -41,10 +41,13 @@ | |||
| <controls:GalleryControlPresenter | |||
| Grid.Row="0" | |||
| Margin="0" | |||
| CodeText="<Image Height="100" Source="Assets\MyImage.jpg" />" | |||
| HeaderText="A basic Image from a local file"> | |||
There was a problem hiding this comment.
I'd recommend leaving the default Image and adding a second one below, ui:Image, to show that there is a choice.
pomianowski
requested changes
Feb 3, 2023
|
Added both |
pomianowski
approved these changes
Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a
ui:ImageControl with CornerRadius, BorderThickness, BorderBrush and BackgroundPull request type
Please check the type of change your PR introduces:
What is the current behavior?
No easy way for an image with rounded corners.
What is the new behavior?
ui:Imagegives access all Image properties with border and corner properties.For Transparent Images, you can set
Backgroundto fill the transparencyOther information