Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving flyout styling #676

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Improving flyout styling #676

merged 4 commits into from
Jun 30, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Jun 28, 2023

Pull request type

This PR fixes the brushes used for flyouts/tooltips so they are inline with the Windows Visual Library design spec. Resolving: #677

AutoSuggestBox
Old:
image
New:
image

Flyout
Old:
image

New:
image

Tooltip
Old:
image

New:
image

ComboBox
Old:
image

New:
image

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@cla-bot
Copy link

cla-bot bot commented Jun 28, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @niels9001 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@niels9001 niels9001 changed the title Niels9001/flyout fixes Improving flyout styling Jun 28, 2023
@niels9001
Copy link
Collaborator Author

@pomianowski Hello :)! I'd love to contribute to this project!

@pomianowski pomianowski changed the base branch from main to development June 30, 2023 07:51
@pomianowski
Copy link
Member

@pomianowski Hello :)! I'd love to contribute to this project!

Hey @niels9001, thanks for your PR. Please note that we are currently working on the 'development' branch.

@pomianowski
Copy link
Member

Hey @niels9001, thanks for your contribution to the project

@pomianowski pomianowski merged commit 23cc5e7 into lepoco:development Jun 30, 2023
1 of 2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants