Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PassiveScrollViewer; replace ScrollViewer in all XAML controls #762

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

koal44
Copy link
Contributor

@koal44 koal44 commented Sep 14, 2023

Implement PassiveScrollViewer across various controls for improved mousewheel behavior

Pull request type

  • Feature

Current Behavior

Currently, many controls in this library use a ScrollViewer, which, while configurable (CanContentScroll, etc) still consumes mousewheel events, leading to a less-than-optimal user experience Stackoverflow. This can be observed within the Gallery app by going to the 'NavigationView' section and attempting to mouse wheel down the page. While replacing .NET's control might seem heavy-handed the only current remedy for app devs is to copy the control and directly replace the style.

New Behavior

  1. Open the Gallery app and go to the 'NavigationView' page
  2. Use the mouse wheel to scroll through the controls down the center of the page (it's cheating if you mouse wheel over the scrollbar).
  3. Optionally, toggle the IsScrollSpillEnabled default value new PropertyMetadata(true)); (PassiveScrollViewer.cs, line 21) and head over to the 'DataGrid' page to observe the difference.

Other information

@github-actions github-actions bot added the controls Changes to the appearance or logic of custom controls. label Sep 14, 2023
@github-actions github-actions bot added the PR Pull request label Sep 20, 2023
@github-actions github-actions bot removed the PR Pull request label Oct 22, 2023
@pomianowski
Copy link
Member

Hey @koal44, thank you for your contributions to the WPF UI. It seems that event bubbling works perfectly and scroll correctly moves to higher controls.

@pomianowski pomianowski merged commit dd2ee94 into lepoco:development Oct 22, 2023
2 checks passed
@koal44 koal44 deleted the feature/passive-scrollviewer branch February 28, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants