Remove ContentAlignment bindings from TreeViewItem #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding to ancestor ControlItem (TreeView), could, under certain conditions, incur binding errors during template switching as visual elements are torn down with TreeView destroyed before item bindings have been released. This fix opts for a more standard and safer styling approach for TreeViewItem that doesn't require binding to an ancestor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Vertical/HorizontalContentAlignmentproperties fromTreeViewItemas it tightly couplesTreeViewtoTreeViewItemthrough an ancestor binding which can lead to binding failures under certain conditions.Pull request type
What is the current behavior?
ContentAlignment style setters such in
TreeViewItem.xamlsuch as:<Setter Property="HorizontalContentAlignment" Value="{Binding Path=HorizontalContentAlignment, RelativeSource={RelativeSource AncestorType={x:Type TreeView}}}" />Issue Number: N/A
What is the new behavior?
The alignment setters have been removed. To re-style the
TreeViewItemcontrols I advise styling the control itself rather than doing so onTreeView.