Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the NumberBox.Value Default UpdateSourceTrigger to LostFocus #767

Conversation

syntax-tm
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Currently the NumberBox.ValueProperty default UpdateSourceTrigger for bindings is UpdateSourceTrigger.Default.

Issue Number: N/A

What is the new behavior?

The NumberBox.ValueProperty default UpdateSourceTrigger for bindings is now UpdateSourceTrigger.LostFocus.

Other information

Since the Value for the NumberBox is a text-based property, Microsoft recommends the default UpdateSourceTrigger should be LostFocus.

The System.Windows.Controls.TextBox documentation says:

When used in data-binding scenarios, this property uses the default update behavior of UpdateSourceTrigger.LostFocus. (source)

…source on LostFocus instead of Default. Also removed the TODO comment pertaining to this.
@cla-bot cla-bot bot added the cla-signed label Sep 23, 2023
@pomianowski pomianowski merged commit d1f0092 into lepoco:development Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants