Fix dynamic style binding #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PlaceholderTextBox FontSize binding Optimized Release version does not output debug files
pomianowski
requested changes
Nov 23, 2023
src/Wpf.Ui/Resources/Theme/Dark.xaml
Outdated
| @@ -17,10 +17,10 @@ | |||
| --> | |||
|
|
|||
| <Color x:Key="ApplicationBackgroundColor">#FF202020</Color> | |||
| <SolidColorBrush x:Key="ApplicationBackgroundBrush" Color="{StaticResource ApplicationBackgroundColor}" /> | |||
| <SolidColorBrush x:Key="ApplicationBackgroundBrush" Color="{DynamicResource ApplicationBackgroundColor}" /> | |||
There was a problem hiding this comment.
Do we really need a dynamic resource if the declaration is before it?
There was a problem hiding this comment.
And if so, it may be worth rebuilding the theme files to contain only Colors and Brushes in a separate, common one.
|
Hey @MakesYT, thank you for your PR, please take a look at the comments |
Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>
Co-authored-by: pomian <13592821+pomianowski@users.noreply.github.com>
|
Now only some system-specific colors are dynamic |
pomianowski
approved these changes
Nov 23, 2023
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PlaceholderTextBox FontSize binding
Optimized Release version does not output debug files
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Fix dynamic style binding
Fix PlaceholderTextBox FontSize binding
Optimized Release version does not output debug files
Other information