Updated NumberBox to use the Width and Height #868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
NumberBox
default style'sTemplate
to use theTemplateBinding
for theWidth
andHeight
properties.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently setting the
Width
property of theNumberBox
will not do anything.Issue Number: N/A
What is the new behavior?
You can set the
NumberBox
Width
andHeight
properties like you would any other control.Other information
The workaround for me has been to put the
NumberBox
inside of aStackPanel
or whatever else and set theWidth
of that control which is annoying.Some parts of the control are only really designed to for the default
Height
of24
so as of now theWidth
property is more practical to set. I would expect the buttons to be centered vertically and theAccentBorder
to be the sameHeight
regardless of the control'sHeight
instead of accenting half of the verticalHeight
.