Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaks in 0.8.3 #16

Closed
opinsky opened this issue Aug 2, 2014 · 4 comments
Closed

breaks in 0.8.3 #16

opinsky opened this issue Aug 2, 2014 · 4 comments

Comments

@opinsky
Copy link

opinsky commented Aug 2, 2014

Hello

this package is not working on meteor 8.3

meteor create yyy
cd yyy
mrt add s3

prevents startup of the application

@Lepozepo
Copy link
Owner

Lepozepo commented Aug 2, 2014

I'll check it as soon as I can. Feel free to open up a pull request though!Marcelo Reyna

On Sat, Aug 2, 2014 at 3:56 PM, opinsky notifications@github.com wrote:

Hello
this package is not working on meteor 8.3
meteor create yyy
cd yyy
mrt add s3

prevents startup of the application

Reply to this email directly or view it on GitHub:
#16

@Lepozepo
Copy link
Owner

Lepozepo commented Aug 3, 2014

Had a chance to take a look, the package is not broken for 0.8.3. It will break your application if you do not give it settings to start off with (the reason you can't just mrt add s3 and see it work). Did you correctly follow step 1?

I am going to patch it to make sure it doesn't break if there are no settings.

Let me know if it's still breaking after following the instructions though, there might be something there I'm not seeing that's not letting me replicate the issue.

@Lepozepo Lepozepo closed this as completed Aug 3, 2014
@opinsky
Copy link
Author

opinsky commented Aug 3, 2014

Marcelo - thank you for the very prompt reply. The following S3methods.js was working on 0.8.2 and is not working anymore after upgrading to 0.8.3.

I can replicate it by creating a new project, adding s3, and adding the s3methods.js file below. The error generated is:

W20140803-16:45:24.786(-3)? (STDERR)
W20140803-16:45:24.897(-3)? (STDERR) /Users/opinsky/.meteor/tools/cef2bcd356/lib/node_modules/fibers/future.js:173
W20140803-16:45:24.897(-3)? (STDERR) throw(ex);
W20140803-16:45:24.897(-3)? (STDERR) ^
W20140803-16:45:24.898(-3)? (STDERR) Error: Method not found [404]
W20140803-16:45:24.898(-3)? (STDERR) at .extend.apply (packages/livedata/livedata_server.js:1378)
W20140803-16:45:24.898(-3)? (STDERR) at .extend.call (packages/livedata/livedata_server.js:1348)
W20140803-16:45:24.899(-3)? (STDERR) at app/S3imageStorage.js:1:43
W20140803-16:45:24.899(-3)? (STDERR) at app/S3imageStorage.js:38:3
W20140803-16:45:24.899(-3)? (STDERR) at /Users/opinsky/Development/xxx/.meteor/local/build/programs/server/boot.js:161:10
W20140803-16:45:24.899(-3)? (STDERR) at Array.forEach (native)
W20140803-16:45:24.900(-3)? (STDERR) at Function.
.each.
.forEach (/Users/opinsky/.meteor/tools/cef2bcd356/lib/node_modules/underscore/underscore.js:79:11)
W20140803-16:45:24.900(-3)? (STDERR) at /Users/opinsky/Development/xxx/.meteor/local/build/programs/server/boot.js:82:5
=> Exited with code: 8

Meteor.call("S3config",{
    key: '###mykey###',
    secret: '###mysecret###',
    bucket: 'mybucket',
    directory: '/images/'
});

Meteor.methods({
    S3callbackFunction:function(url,context) {
        console.log('Add '+url+' to the id of '+context);
        console.log(context._id);
        console.log(context.name);
    },
    locationImageL_callback: function(url, context) {
      console.log('added ' + url + ' to ' + context.name + ' ImageL');
      Locations.update(context._id, {$set: {imageL: url}});
    },
    locationImageS_callback: function(url, context) {
      console.log('added ' + url + ' to ' + context.name +' ImageS');
      Locations.update(context._id, {$set: {imageS: url}});
    },
    eventImage_to_S3: function(url, context) {
      eventImage = {
        eventId: context._id,
        imageURL: url,
        created_at: new Date()
      }

      EventImages.insert(eventImage,function(error) {
        if (error)
          console.log(error.reason)
        else
          console.log('added ' + url + 'to ' + context.name + ' (eventImage collection');
      })
    }
});

@Lepozepo
Copy link
Owner

Lepozepo commented Aug 3, 2014

Yup, it seems you're doing step 1 the old way, lol. Try this:
screen shot 2014-08-03 at 12 47 33 pm

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants