Whitespace, than backslash compile fix #89
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better not to remove whitespace if followed by backslash. Fixes leproxy#88
|
@gtgt Thanks for creating this pull request 👍 The description you provided doesn't really say much about the reason for your suggested changes, can you go a bit more into detail on why you want to change this? Additionally, this pull request doesn't touch any of the tests, but I think we need some adjustments or some additional tests in order to confirm that your change works as expected. The test suite is currently failing and needs some adjustments as I described in #90 and #88, so in order to get the checks in here green, we'll first have to take a look at updating our test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better not to remove whitespace if followed by backslash.
Fixes #88