Rewrite some preview callbacks in Scheme #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function call has been moved from schematic_file_select_dialog_new() to Scheme. In order to make things work again, the function type has been changed to GtkWidget*.
The name of the module is (schematic preview-widget). An only function residing there is init-preview-widget-signals() which initializes Glib signals of preview widgets.
The callback that updates the preview in the File select dialog can now be used as a foreign C function in Scheme.
A signal has been added to allow for calling this callback instead of a direct call. This allowed for moving the connection of the signal to Scheme code, which in future will facilitate refactoring the callback in Scheme.
The previous C callback has been renamed as it is just a foreign function used in Scheme.
A real getter that will be used in upper level code will return the value of 'preview->filename'.
This allows to eliminate references to lowlevel defines in C code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview widget are now available for dealing with in Scheme.
made available for Scheme FFI. The
SchematicPreviewstructurehas been made opaque.
(schematic preview-widget), has been added to work with themin Scheme.
assigned in Scheme. The function
init-preview-widget-signals()has been factored out for thistask.
widget to allow for updating the widget directly in Scheme. A C
callback it first used, has been wholly rewritten in Scheme.
rewritten in Scheme as well.
Long story short, all this has allowed me to move one call for
f_open()and one call foro_read_buffer()to Scheme, whichwill facilitate access to lower level Scheme-in-C functions in
future.