Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics of input file errors #268

Merged
merged 8 commits into from Nov 3, 2018

Conversation

graahnul-grom
Copy link
Member

  • make lepton-schematic print input file line by line when invoked with -v (--verbose) flag
  • better "Failed to load file" error message (include line number where the parser was stopped)

tb_083_parse_verb_screenshot

Add linenum field to track the number of
lines read so far. Increment it each time
s_textbuffer_next_line() is called.
Pass the name of the buffer which will be displayed
in verbose output.
When verbose_loading is set, print input files
line by line as they are parsed.
Set liblepton's verbose_loading global variable
if --verbose (-v) command line option is passed
to lepton-schematic.
Reformat, replace "gschem" with "lepton-schematic",
offer to use --verbose command line option.
Return current line number of a given TextBuffer
(lenenum field).
If an error occur during the parsing of input file,
add line number information to the error message.
Report line number where the parsing process is stopped.
@vzh vzh merged commit c5ce262 into lepton-eda:master Nov 3, 2018
@vzh
Copy link
Member

vzh commented Nov 3, 2018

@graahnul-grom, thanks! Please update NEWS as well.

@vzh vzh added this to the 1.9.7 milestone Nov 3, 2018
@graahnul-grom graahnul-grom deleted the tb_083_parse_verb branch January 30, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants