Fix postscript output in landscape orientation #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matrix has been rewritten and supplied with comments showing how transformations are going. This will allow for further PS transformations, and seems to be simpler to understand. Well, I did so because the further transformation functions I need must be called before the transformations described by the matrix, and I don't know how to make a new matrix to address this.
Postscript output must always go in Portrait orientation, so appropriate transformations have been applied to ensure this and proper view in PS viewers. Please see https://www.cairographics.org/documentation/using_the_postscript_surface/ for more information. Reported-by: Karl Hammar on the geda-help mailing list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by Karl Hammar.
gaf exporttrimmed Postscript output for landscape pages since there were no special handing for it in code.For more details on why the previous code worked incorrectly, please see this link
Since proposed PR's commits affect output in other formats,
and we have no automated tests for
gaf exportyet, testing ismuch appreciated. The more the better :-) I tested only output for all formats on
several schematic files with or without margins and using a different scale. As for plain PS,
gs,gvandgv -nodscshowed correct output (evincesegfaulted on landscaped PS pages, though it looks like a bug in it or in its libraries).