Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: change 'memoizes' to 'memorizes' in 06_control_flow.md #104

Closed
wants to merge 1 commit into from

Conversation

NCura
Copy link
Contributor

@NCura NCura commented Jun 4, 2024

Description

Hello, this is my first time contributing to open-source, and I'm excited to be able to help out!

I found a typo in the 06_control_flow and have submitted a pull request to fix it. I've changed the word 'memoizes' to 'memorizes'.

Additional Information

Please let me know if there's anything I can do to improve the changes or if there are any additional steps I need to take. I'm eager to learn and contribute more to the project.

Thank you for your time and consideration!

@gbj
Copy link
Contributor

gbj commented Jun 4, 2024

Thanks for the contribution! "Memoization" here isn't a typo for "memorization" but is a technical term for a certain kind of cached computation. Given that these are intro docs we should probably add a note clarifying that for others, as simply using an unknown term is not helpful to someone trying to learn!

@NCura
Copy link
Contributor Author

NCura commented Jun 4, 2024

🤦 good to know, thank you!

@NCura
Copy link
Contributor Author

NCura commented Jun 4, 2024

By the way, if I come across other potential typos while reading, should I create a separate pull request for each one, or should I wait until I've finished reading the book and submit a single pull request with a commit for each typo fix?

@gbj
Copy link
Contributor

gbj commented Jun 4, 2024

Making individual PRs as you go is great!

@gbj gbj closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants