Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordered list numbering in SSR modes page #90

Conversation

yasutakekazu
Copy link
Contributor

Fixed ordered list numbering in SSR modes page!

@yasutakekazu yasutakekazu changed the title fix: Update ordered list numbering in SSR modes page Fix ordered list numbering in SSR modes page Apr 5, 2024
@gbj
Copy link
Contributor

gbj commented Apr 5, 2024

Using numbers like

1.
1.
1.

in Markdown should cause them to be rendered correctly, without needing to fix/update the numbering if an item is inserted earlier in the list. Here's how it shows in the deployed version, for me -- Are you seeing something different?

Screenshot 2024-04-05 at 2 09 18 PM

@yasutakekazu
Copy link
Contributor Author

You're right, and I see the same rendering with the numbered list as you do. Other Markdown files in the project use sequential numbering, and it didn't seem intentional that this file alone used repeated '1's. I agree that Markdown's auto-numbering is a clear advantage, saving manual effort. If this is by design, I understand and feel free to close this PR. I appreciate your consideration.

@yasutakekazu
Copy link
Contributor Author

It's not good to leave it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants