tweaks for hash_file #282
Merged
tweaks for hash_file #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maccesch
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd appreciate a code review on this as i'm pretty new to contributing to open source rust.
In Cargo.toml one can add
hash-file-name="my-hash-file.txt"
(it was erroneously checking for "hash-file" instead of "hash-file-name"). This is potentially a breaking change but shouldn't affect anyone since it was a bug to begin with?
Ensure the environment variable LEPTOS_HASH_FILE_NAME is allowed.
fix the directory of hash.txt when cross compiling by using the exact directory that the binary is in.
Cheers
fixes: #278