Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer or remove Viz integration? #2177

Closed
gbj opened this issue Jan 11, 2024 · 2 comments
Closed

Transfer or remove Viz integration? #2177

gbj opened this issue Jan 11, 2024 · 2 comments
Milestone

Comments

@gbj
Copy link
Collaborator

gbj commented Jan 11, 2024

Is your feature request related to a problem? Please describe.
@fundon contributed a server integration for the Viz framework last year. In the time since, it's been maintained somewhat in parallel with the other server integrations, but has not been updated meaningfully. For example, the Axum integration was rewritten to be less bad, but the same work was not done for Viz. Likewise, the current published version uses Viz 0.4.8, hyper 0.14, and http 0.2, while the current published version of Viz is 0.7.1 and uses hyper 1.0 and http 1.0.

With the ongoing server function rewrite as part of 0.6, the Viz integration is now broken. I don't have the knowledge or capacity to update the Viz integration to hyper/http 1, viz 0.7, and the new server functions.

Describe the solution you'd like
I think my preference would be for the leptos_viz crate to be handed off to @fundon to maintain. I don't think enough knowledge of the framework exists in the community for it to be maintained as part of this core repo.

Describe alternatives you've considered
An update PR to bring it into a working state would also be welcome as an alternative.

For now, I will just disable CI running on it, and not publish new versions.

@gbj gbj added this to the 0.6 milestone Jan 11, 2024
gbj added a commit that referenced this issue Jan 11, 2024
@fundon
Copy link
Contributor

fundon commented Jan 11, 2024

Hi @gbj,

Thanks for the feedback, you can transfer leptos_viz to me.
I'm happy to maintain it and keep up with leptos changes.

@gbj
Copy link
Collaborator Author

gbj commented Jan 11, 2024

Okay, great! I've invited you to ownership of the leptos_viz crate on crates.io, and removed the integration from this repo in this commit to the leptos_v0.6 branch 45dfb96

@gbj gbj closed this as completed Jan 11, 2024
gbj added a commit that referenced this issue Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants