You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using on:close on an <dialog> tag does not execute the given callback although it is listed under event listeners in dev tools.
Adding the #[does_not_bubble] attribute to my local leptos source seemed to fix it for me as I saw it was not marked with it and mdn says it does not bubble.
I dont know if there are any other tags that use this event and might break after this change but it seems to be the only real dom element to use some sort of close event.
Link to list of all events
Searching for close there only yields events in WebSocket, RTCDataChannel, IDBDatabase and the HTMLDialogElement.
So I think its pretty save to just add the attribute as all the other usecases are not DOM related.
The text was updated successfully, but these errors were encountered:
Using
on:close
on an<dialog>
tag does not execute the given callback although it is listed under event listeners in dev tools.Adding the #[does_not_bubble] attribute to my local leptos source seemed to fix it for me as I saw it was not marked with it and mdn says it does not bubble.
I dont know if there are any other tags that use this event and might break after this change but it seems to be the only real dom element to use some sort of close event.
Link to list of all events
Searching for close there only yields events in WebSocket, RTCDataChannel, IDBDatabase and the HTMLDialogElement.
So I think its pretty save to just add the attribute as all the other usecases are not DOM related.
The text was updated successfully, but these errors were encountered: