Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axum): provide state to server fn context #2257

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

chrisp60
Copy link
Contributor

@chrisp60 chrisp60 commented Feb 4, 2024

Note that this is a minimal implementation and will not allow the
user to expect_state if they have external calls to rendering their
app (i.e. using render_app_to_* directly).

Additional work should be taken up to outline these changes through documentation.
Unfortunately, my personal work takes up most of my time right now.

Note that this is a minimal implementation and will __not__ allow the
user to `expect_state` if they have external calls to rendering their
app (i.e. using `render_app_to_*` directly).
@chrisp60
Copy link
Contributor Author

chrisp60 commented Feb 4, 2024

oof did I screw something up or has CI just been fussy recently. I can take a deeper look if its needed

@gbj
Copy link
Collaborator

gbj commented Feb 5, 2024

It's not you, it's clippy testing rkyv and feeling sad.

This looks great -- thanks!

@gbj gbj merged commit 15d4ca0 into leptos-rs:main Feb 5, 2024
44 of 60 checks passed
@chrisp60 chrisp60 deleted the feat-axum-provide-state-context branch February 5, 2024 01:10
gbj pushed a commit that referenced this pull request Feb 8, 2024
Note that this is a minimal implementation and will __not__ allow the
user to `expect_state` if they have external calls to rendering their
app (i.e. using `render_app_to_*` directly).
videobitva pushed a commit to videobitva/leptos that referenced this pull request Feb 17, 2024
Note that this is a minimal implementation and will __not__ allow the
user to `expect_state` if they have external calls to rendering their
app (i.e. using `render_app_to_*` directly).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants