Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error type detection only worked without type path #2298

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

maccesch
Copy link
Contributor

In most cases when you return Result<..., ServerFnError<E>> this worked but when you tried Result<..., leptos::ServerFnError<E>> then it didn't.

In most cases when you return `Result<..., ServerFnError<E>>` this worked but when you tried
`Result<..., leptos::ServerFnError<E>>` then it didn't.
@gbj
Copy link
Collaborator

gbj commented Feb 13, 2024

Thanks! As the change suggests, clearly I intended this and then missed that reference 😄 Good catch.

@maccesch
Copy link
Contributor Author

Happened to me various times. Macro code is very finicky to write.

I think the 2 failing checks are not because of my code.

@gbj gbj merged commit 23bc892 into leptos-rs:main Feb 16, 2024
56 of 60 checks passed
@gbj
Copy link
Collaborator

gbj commented Feb 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants