Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to RouteContext (#1808) #2315

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

zoomiti
Copy link
Contributor

@zoomiti zoomiti commented Feb 16, 2024

Closes #1808

@zoomiti
Copy link
Contributor Author

zoomiti commented Feb 16, 2024

@yokomizer is this a solution that works for your use case?

@zoomiti
Copy link
Contributor Author

zoomiti commented Feb 16, 2024

This is the second time server_fn has failed to run its CI on my PR's. I want to look into this

@gbj
Copy link
Collaborator

gbj commented Feb 16, 2024

@zoomiti The server fn CI issue is just that there are now so many features to enable all the encodings that, when the CI runs, it runs out of space checking all the combinations. We just need to disable some of the feature combos and it will be fine.

@zoomiti
Copy link
Contributor Author

zoomiti commented Feb 16, 2024

I forgor to add docs to the new method

@gbj gbj merged commit 4809cf4 into leptos-rs:main Feb 27, 2024
57 of 60 checks passed
@gbj
Copy link
Collaborator

gbj commented Feb 27, 2024

Thanks, this looks great! A clever way of handling it that I had not thought of (providing it via context, on the server). 🎉

@zoomiti
Copy link
Contributor Author

zoomiti commented Feb 27, 2024

Unless I'm wrong I thought this was your idea!
#1808 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RouteContext::method
2 participants