Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Doc links and Deprecate FromUtf8Error in oco.rs #2318

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

zoomiti
Copy link
Contributor

@zoomiti zoomiti commented Feb 16, 2024

Potentially fixes #859

The relative paths for some doc links comes inspired from what tokio does for its workspace links. See here for an example.

@benwis
Copy link
Contributor

benwis commented Feb 19, 2024

Can you run cargo fmt on your PR?

@benwis
Copy link
Contributor

benwis commented Feb 22, 2024

Thanks for looking into this!

@benwis benwis merged commit 753bf1e into leptos-rs:main Feb 22, 2024
45 of 60 checks passed
@gbj
Copy link
Collaborator

gbj commented Feb 24, 2024

I'm removing the deprecation with #2362. Adding deprecation warnings can be tricky, since adding them in a patch release can cause previously-passing CI to fail if it is set up to deny based on clippy warnings. This was happening in our own repo after this change; I would not have expected it to be a problem, but clippy was warning about the use of it in leptos_reactive itself when run in leptos_dom etc. You can see the warning showing up in CI for recent PRs.

warning: use of deprecated enum `oco::FromUtf8Error`: This error was intended for a `TryFrom` implementation for `Oco`. `Oco` will likely move to its own crate after 0.7 so this type will be removed in the future
   --> leptos_reactive/src/oco.rs:450:10
    |
450 | pub enum FromUtf8Error {
    |          ^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Doc Links across Crates
3 participants