feat: add impl_from argument to #[server] proc_macro
#2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbj
reviewed
Feb 19, 2024
Rename `impl_into` back to be `impl_from` Rework docstring
videobitva
changed the title
impl_from argument to #[server] proc_macro
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
impl_fromnamed argument forserver_fnproc macro.This argument defaults to
trueand enables (or disables) the impl ofFromtrait for server function argument type.In cases when the server function has more than one argument, the
impl_fromhas no effect on the trait impl generation, as it has been already disabled by function arguments number check.The related issue has been discussed here: https://discord.com/channels/1031524867910148188/1203001939089035295
TL;DR: orphan rules disable (in some cases) the implementation of
Fromtrait for conversion between the only server function argument and server function argument type.The minimal example of the issue lives here: https://github.com/videobitva/test_server_fn