Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSRV #2360

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add MSRV #2360

merged 2 commits into from
Feb 28, 2024

Conversation

paul-hansen
Copy link
Contributor

Adds a Minimum Supported Rust Version using the rust-version field.

Current motivation for this is we are seeing people try to compile Leptos with older versions of Rust and it's failing with confusing error messages. With this PR it now gives a nice error message letting them know which version to upgrade to.

I simply chose Rust 1.75 because it's the oldest that compiles currently. Lmk if we want to use something newer.

You can test this by running this from the project root:

rustup install 1.74
rustup default 1.74
cargo build

Which using this PR will now output:

error: package leptos_macro v0.6.6 (/home/paul/Projects/Rust/leptos/leptos_macro) cannot be built because it requires rustc 1.75 or newer, while the currently active rustc version is 1.74.1

I added it to the stable examples as well, the nightly examples already enforce a version in their rust-toolchain.toml files.

@paul-hansen
Copy link
Contributor Author

paul-hansen commented Feb 24, 2024

Reviewed CI failures and they all seem unrelated to me. Let me know if I missed anything though.

Also lmk if they get fixed and I can rebase and we can run them again if we want.

@gbj
Copy link
Collaborator

gbj commented Feb 28, 2024

Thanks!

@gbj gbj merged commit 6a83161 into leptos-rs:main Feb 28, 2024
45 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants