Dedup from_str implementations for Env #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-re-g
force-pushed
the
dedup_from_str
branch
from
0e66dd6
to
935d32f
Compare
|
LGTM, it's a fairly straightforward cleanup. Thanks for doing this |
|
Looks good to me as well |
gbj
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is wanted or needed, was reading through the code to get a better understanding of how leptos works under the hood and saw some duplication. Figured I'd edit it and put up a PR. :) I'm happy to change it however folks want / delete the PR if it's not needed or wanted!
Some nice things: