Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal traits #490

Merged
merged 37 commits into from
Feb 18, 2023
Merged

Signal traits #490

merged 37 commits into from
Feb 18, 2023

Conversation

jquesada2016
Copy link
Contributor

This is intended to be a largish PR. The theme of this game is to make all core shared methods on signals into traits. I have added try_ variants to all of them. The Untracked* traits also need to be updated, but perhaps in a future PR, as this one is large enough as is.

@gbj gbj marked this pull request as ready for review February 7, 2023 22:29
@gbj gbj mentioned this pull request Feb 11, 2023
22 tasks
@gbj
Copy link
Collaborator

gbj commented Feb 11, 2023

Thanks. I just looked over this and it looks like reverting the changes to StoredValue is the only thing missing that I can see.

I am also thinking that signals could be a better module name than signal_prelude, so that someone can use leptos::signals::*;

I'm going to do some work on reorganizing the other re-exports now too.

@gbj gbj merged commit f2f52b2 into leptos-rs:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants