change: add Scope to view function in <For/> to avoid memory "leak"
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbj
changed the title
Scope to view function in <For/> to avoid memory leakScope to view function in <For/> to avoid memory "leak"
gbj
added a commit
that referenced
this pull request
Feb 12, 2023
gbj
added a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, because the
each_fndoesn’t take a Scope as one of its arguments, eachEachItemis rendered with the scope of theEachitself. This means that if there are dynamic children for example thecreate_effectwill be created on the scope of theEach, not theEachItem, so it will be disposed eventually but not when the row is destroyed. This means as you create and destroy rows you keep allocating more and more signals.