-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: viz integration #506
Conversation
Cool! Are you still working on the integration or is this ready to review? EDIT: Never mind you titled it WIP haha. Just let me know when it's ready. |
I'm done updating and ready to review. |
24a2e71
to
b23a316
Compare
Thanks for your work on this. I'm not very familiar with Viz, but it looks like the internals are very similar to Axum... diffing this against the Axum integration it looks like there's a lot of shared code that could probably do with a refactor. Same goes for the examples, of course. I'm working on another PR that is already doing some refactoring of the integrations, so I'm happy to take this as is for now, and handle the refactoring as part of that other work. On the examples, on the other hand — rather than duplicating three existing examples, could you please pick one to highlight Viz and remove the other two? This will reduce the maintenance burden for me over time if and when we need to update the application code in examples. |
Thank you for your reply. Yes, they are somewhat similar. We can extract some common functions. I'll wait for you to finish that PR and refactor this one. It feels like we can just keep the sqlite example. |
@fundon I've merged the other PR — So if you compare what you did for |
979b3f9
to
c9dbfc5
Compare
@gbj I have merged the latest changes and only keep the sqlite example. If you come across viz related later, you can tell me and I can maintain this part of the code. :) |
Thanks! This is great. The doctests are failing on
|
a972da6
to
b590a27
Compare
b590a27
to
2f57933
Compare
@gbj It has been fixed. |
Thanks for your work! I've merged this. I'll release a |
Viz is a fast, flexible, lightweight web framework.
Repo: https://github.com/viz-rs/viz
Website: https://viz.rs/
If you don't think it makes sense to put it in the leptos project, you can close it. :)