In Axum Integration Remove unwrap() from redirect function #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fundon
added a commit
to fundon/leptos
that referenced
this pull request
Feb 14, 2023
* main: Reexport `web-sys` event types in `leptos::ev` to make it easier to type handlers (leptos-rs#521) fix: correct namespace for `Unit` in empty views (closes leptos-rs#518) (leptos-rs#520) leptos_dom erros.rs remove<E>() does not need to be generic. (leptos-rs#516) `0.2.0-alpha` (leptos-rs#515) remove `.unwrap()` from `redirect` in Actix integration (leptos-rs#514) do not unwrap use_context in integrations axum redirect (leptos-rs#513) CI: fix Wasm testing (leptos-rs#511) fix: SSR export in Wasm mode (leptos-rs#512) fix: import in `leptos_dom` and add Wasm build to CI for regressions (leptos-rs#510) Typos and a small cleanup (leptos-rs#509) change: reorganize module exports and reexports (leptos-rs#503) Add docs on testing (closes leptos-rs#489) (leptos-rs#508)
gbj
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to allow users to remove additional boilerplate of ensuring that there is a ResponseOptions present before calling leptos_axum::redirect().
ResponseOptions do not exist during startup of the server when leptos_axum::generate_route_list() is called.
During the route building phase the Response does not need to be updated since it does not exist and the function can return immediately without a panic.