change: tweak API of Errors and implement IntoIter
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwis
requested changes
Feb 14, 2023
| .into_iter() | ||
| .filter_map(|(_k, v)| v.downcast_ref::<TodoAppError>().cloned()) | ||
| .filter_map(|(_, v)| v.downcast_ref::<TodoAppError>().cloned()) | ||
| .collect(); | ||
| println!("Errors: {errors:#?}"); |
There was a problem hiding this comment.
I probably did this, but we can remove this println!
| #[derive(Debug, Default, Clone, PartialEq, Eq, Hash)] | ||
| pub struct ErrorKey(String); | ||
|
|
||
| impl<T> From<T> for ErrorKey |
There was a problem hiding this comment.
I think this is good, but I should ask whether we make any assumptions elsewhere that this is a valid HydrationKey? I set it outside leptos with a default for 404, but is there a cleanup function somewhere that might need this to be valid?
There was a problem hiding this comment.
Same rough idea, making this private is probably the right way to go, but there are a lot of possible things people can do to a HashMap. As long as we're okay with limiting those, this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking about how to limit the API surface of
Errorsso we aren't committed to any particular internal implementation. I'm hoping to achieve the following with this PR:HashMapforever without being able to switch to another data structureIntoIterso you can just do thiserrors.get().0and friends@benwis I'd like you to review this because a) it's your creation originally and b) without a doubt you're using this in more places than anyone else. Remember it's a lot easier for us to add additional methods in the future (not a breaking change to add a method) than to remove them or change them (breaking changes).