Identify CSS to reload from the href #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akesson Is the actix one supposed to be matching "fail"? |
|
🤦 Thanks @benwis for spotting that. It was for testing the error message. |
|
Other than that, It looks fine to me. I see no reason Axum would work any differently than Actix here. I tried it and it seems sane |
|
Yep looks good to me. I'm doing a little refactoring into a |
gbj
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the CSS to reload from the href, which is already sent to the browser in the WebSocket message, instead of using the CSS
id.This opens the possibility to have more than one CSS file that is hot-reloaded by
cargo-leptos. I plan on using that for the Tailwind implementation.This is backwards compatible with previous
cargo-leptosversions.@benwis Ok for you? I have to admit that I didn't test it with an Axum setup as I don't have one easily available. Would appreciate it if you could test it!
@gbj I would be really good to include this in release 0.2.0.