Merge pull request #544 from schnerd/uri-none-check

lepture · Jun 7, 2023 · cadc55d · cadc55d
2 parents 70a6bfa + 6cbab3a
commit cadc55d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/authlib/oauth2/rfc6749/parameters.py b/authlib/oauth2/rfc6749/parameters.py
@@ -60,7 +60,7 @@ def prepare_grant_uri(uri, client_id, response_type, redirect_uri=None,
         params.append(('state', state))
 
     for k in kwargs:
-        if kwargs[k]:
+        if kwargs[k] is not None:
             params.append((to_unicode(k), kwargs[k]))
 
     return add_params_to_uri(uri, params)

diff --git a/tests/core/test_oauth2/test_rfc6749_misc.py b/tests/core/test_oauth2/test_rfc6749_misc.py
@@ -50,6 +50,13 @@ def test_parse_implicit_response(self):
             rv,
             {'access_token': 'a', 'token_type': 'bearer', 'state': 'c'}
         )
+
+    def test_prepare_grant_uri(self):
+        grant_uri = parameters.prepare_grant_uri('https://i.b/authorize', 'dev', 'code', max_age=0)
+        self.assertEqual(
+            grant_uri,
+            "https://i.b/authorize?response_type=code&client_id=dev&max_age=0"
+        )
 
 
 class OAuth2UtilTest(unittest.TestCase):