Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't provide redirect_uri in OAuth2Session.authorization_url() call #39

Closed
codemug opened this issue Apr 5, 2018 · 3 comments
Closed
Milestone

Comments

@codemug
Copy link

codemug commented Apr 5, 2018

The authorization_url method takes a kwargs as an argument in which we can provide redirect_uri. The flow is correctly wired. There's just the conflict of redirect_uri being passed separately in the prepare_grant_uri method which results in:

TypeError: prepare_grant_uri() got multiple values for keyword argument 'redirect_uri'

@lepture
Copy link
Owner

lepture commented Apr 5, 2018

By current design, redirect_uri should be provided when initializing OAuth2Session.

@codemug
Copy link
Author

codemug commented Apr 5, 2018

I understand that, I'm just suggesting an improvement since this provides the leeway to provide it at the time of authorization

@lepture
Copy link
Owner

lepture commented Apr 5, 2018

@codemug thanks for your feedback, it is fixed.

@lepture lepture closed this as completed Apr 5, 2018
@lepture lepture added this to the Version 0.7 milestone Apr 7, 2018
coopfeathy added a commit to coopfeathy/authlib-django that referenced this issue Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants