Import private httpx modules

[suud]

The public api of httpx has changed in version 0.12.1.

Fixes: #208

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update
• Refactor
• Other, please describe:

Does this PR introduce a breaking change?

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

• Not compatible with httpx<0.12.0: the httpx library has to be updated to a version >=0.12.0 in existing applications. EDIT: Fixed with 116988b as suggested by @phy25 in Import private httpx modules #209 (comment)
• Depends on some private modules from httpx: as explained in incompatibility with new httpx version #208. I hope somebody will come up with a better solution than mine!

---

• You consent that the copyright of your pull request source code belongs to Authlib's author.

[phy25]

I think a try...catch ImportError... with attempts of different namespaces would be better?

[pdiwan]

@lepture could you please get this fix merged? This is a blocking bug for me.

[lepture]

@pdiwan you can use the old version of httpx. It shouldn't be a blocking issue.

[pdiwan]

I could but just trying to avoid hardcoding versions now and later change when the fix is merged.

[lepture]

I don't think it is a good idea to import from private modules. I need to ask @encode team to make it public.

[tomchristie]

So, it's not obvious to me that the rebuild_request function needs to be written in a way that uses private API here. Can you change that function instead? Perhaps like so...

def rebuild_request(request, url, headers, body):
    method = request.method
    headers = Headers(request.headers)
    headers.update(headers)
    return Request(method=method, url=url, headers=headers, body=body)

[lepture]

@tomchristie unfortunately, there is no body parameter in Request.

[tomchristie]

Let me rephrase that. content=...

[lepture]

@tomchristie there is no content either, the only available parameter would be data= (I think). But this rebuild_request is used in auth_flow, and it is requires_request_body = True. The request returned by rebuild_request is not read or aread yet, thus this request would not have .content property.

[lepture]

@tomchristie it would also be helpful if we can add a property setter on Request:

    @content.setter
    def content(self, value: bytes) -> None:
        self._content = value
        self.stream = ByteStream(self._content)

Do you think it is ok to add this setter?

[lepture]

Please pin httpx version.

[lepture]

This module will be changed again in v0.13. That's why I'd like to keep our current implementation.

[tomchristie]

An alternative to using the private dispatch API here would be to implement the stubs as either ASGI or WSGI applications, and use Client(app=wsgi_app) or AsyncClient(app=asgi_app).