Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ever-growing session cookie (starlette integration) #644

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion authlib/integrations/starlette_client/integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,15 @@ async def get_state_data(self, session: Optional[Dict[str, Any]], state: str) ->
return None

async def set_state_data(self, session: Optional[Dict[str, Any]], state: str, data: Any):
key = f'_state_{self.name}_{state}'
key_prefix = f'_state_{self.name}_'
key = f'{key_prefix}{state}'
if self.cache:
await self.cache.set(key, json.dumps({'data': data}), self.expires_in)
elif session is not None:
# clear old state data to avoid session size growing
for key in list(session.keys()):
if key.startswith(key_prefix):
session.pop(key)
now = time.time()
session[key] = {'data': data, 'exp': now + self.expires_in}

Expand Down
Loading