Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setup.py] Please add missing install_require dependency on pkg_resources #168

Closed
P-EB opened this issue May 2, 2018 · 5 comments
Closed

Comments

@P-EB
Copy link
Contributor

P-EB commented May 2, 2018

Hi,

We realized in Debian that your python module's setup.py doesn't state that pkg_resources is required at installation by livereload while it's used in handlers.py.

Could you add it as a dependency in the setup.py file, please? :)

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=896399 or https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=896315 for more intel.

@P-EB P-EB changed the title [setup.py] [setup.py] Please add missing install_require dependency on pkg_resources May 2, 2018
@RonnyPfannschmidt
Copy link
Contributor

it should be noted that the "pkg_resources" package is only existing on debian as a rotten bad hack to split it out of setuptools and the correct python level dependency is setuptools

@RonnyPfannschmidt
Copy link
Contributor

i propose using pkgutil.get_data as it seems sufficient for the use-case

lepture added a commit that referenced this issue May 2, 2018
@lepture
Copy link
Owner

lepture commented May 2, 2018

@RonnyPfannschmidt I changed to file open and read.

@lepture
Copy link
Owner

lepture commented May 2, 2018

2.5.2 released

@lepture lepture closed this as completed May 2, 2018
@P-EB
Copy link
Contributor Author

P-EB commented May 2, 2018

Thanks for the intel, and the fix. :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants