Fix bug where pickle protocol is ignored

Fixes #252
lericson · Aug 15, 2019 · d8bafe9 · d8bafe9
1 parent b6cd043
commit d8bafe9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/_pylibmcmodule.c b/src/_pylibmcmodule.c
@@ -148,6 +148,8 @@ static int PylibMC_Client_init(PylibMC_Client *self, PyObject *args,
     PyObject *behaviors = NULL;
     memcached_return rc;
 
+    self->pickle_protocol = -1;
+
     static char *kws[] = { "servers", "binary", "username", "password",
                            "behaviors", NULL };
 
@@ -216,8 +218,6 @@ static int PylibMC_Client_init(PylibMC_Client *self, PyObject *args,
     }
     self->native_deserialization = (uint8_t) native_deserialization;
 
-    self->pickle_protocol = -1;
-
     while ((c_srv = PyIter_Next(srvs_it)) != NULL) {
         unsigned char stype;
         char *hostname;

diff --git a/tests/doctests.txt b/tests/doctests.txt
@@ -321,6 +321,11 @@ True
 >>> mc.get('foo')
 ('bar', 'quuz')
 
+With reference to bug #252
+>>> c = make_test_client(behaviors={'pickle_protocol': 2})
+>>> int(c.behaviors['pickle_protocol'])
+2
+
 Compression shouldn't break anything
 >>> c = make_test_client(_pylibmc.client, binary=True)