Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py3.12 #286

Merged
merged 3 commits into from
Oct 11, 2023
Merged

add py3.12 #286

merged 3 commits into from
Oct 11, 2023

Conversation

davidszotten
Copy link
Contributor

is anything else needed to get a python 3.12 wheel? thanks!

@lericson lericson merged commit 1223712 into lericson:master Oct 11, 2023
7 checks passed
@davidszotten
Copy link
Contributor Author

oh wow, that was quick. unfortunately i'm not sure this is enough. made a temp commit to test the wheel building https://github.com/davidszotten/pylibmc/actions/runs/6480516499/job/17596188708 and it's not building for 3.12. working to figure out why (unless you know?)

@lericson
Copy link
Owner

ISTM that cibuildwheel is what is actually creating per-version wheels, and it is not generating an artifact for Python 3.12.

@lericson
Copy link
Owner

lericson commented Oct 11, 2023

According to its documentation:

⁵ CPython 3.12 is built by default using Python RCs, starting with cibuildwheel 2.15.

According to the build log:

Downloading cibuildwheel-2.13.1-py3-none-any.whl.metadata (22 kB)

I think it is because the CD script is using Python 3.7 and cibuildwheel is no longer being released for that ancient version.

@davidszotten
Copy link
Contributor Author

thanks, was just discovering the same thing. since 3.7 is eol, what do you think about dropping support for it?

@davidszotten
Copy link
Contributor Author

actually, maybe it's enough to stop building wheels for 3.7 (by running cibuildwheel on 3.8). testing that now. we may of course still want to stop supporting eol pythons

@davidszotten
Copy link
Contributor Author

ok that seems to work. how does publishing work atm? the upload part is commented out in the workflow

@lericson
Copy link
Owner

I upload it manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants