Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: use lerna CLI for all commands, fixes #28 #46

Merged
merged 7 commits into from
Mar 15, 2022

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Mar 12, 2022

  • replace ws-roller and ws-runner CLIs by lerna all-in-one CLI to make it simpler for everyone to migrate and use Lerna-Lite
  • keep run as optional, it will display an error when user forgot to install it
  • add more unit tests with helper command-runner that was missing before
  • fixes issue Any plans to rename cli? #28

- keep `run` as optional, it will display an error when user forgot to install it
- add more unit tests with helper command-runner that was missing before
- fixes issue #28
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #46 (35f2800) into main (b139048) will increase coverage by 2.79%.
The diff coverage is 86.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   85.27%   88.06%   +2.79%     
==========================================
  Files         115      115              
  Lines        3326     3390      +64     
  Branches      665      664       -1     
==========================================
+ Hits         2836     2985     +149     
+ Misses        490      405      -85     
Impacted Files Coverage Δ
packages/cli/src/cli.ts 0.00% <0.00%> (ø)
packages/cli/src/lerna-entry.ts 0.00% <0.00%> (ø)
packages/core/src/utils/index.ts 100.00% <ø> (ø)
packages/publish/src/index.ts 100.00% <ø> (ø)
packages/run/src/lib/index.ts 100.00% <ø> (ø)
packages/version/src/index.ts 100.00% <ø> (ø)
packages/version/src/version-command.ts 98.80% <75.00%> (ø)
packages/publish/src/publish-command.ts 95.52% <80.00%> (ø)
packages/run/src/run-command.ts 93.66% <85.72%> (ø)
packages/cli/src/cli-commands/cli-run-commands.ts 90.91% <90.91%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe55bf...35f2800. Read the comment docs.

@ghiscoding ghiscoding merged commit 49d2fa1 into main Mar 15, 2022
@ghiscoding ghiscoding deleted the chore/lerna-cli branch March 15, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant