Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): recover from network failure #469

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Jan 31, 2023

Description

As per Lerna PR 3513

Catches the EPUBLISHCONFLICT error from npm when a version already exists. In this case, Lerna assumes that you have already published the package.

Motivation and Context

As per Lerna PR

This allows lerna publish from-git to be idempotent. If one or more packages fail to publish, then you can rerun lerna publish from-git to publish the packages that failed.

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #469 (d95568d) into main (a86061f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   97.38%   97.43%   +0.05%     
==========================================
  Files         154      154              
  Lines        4536     4546      +10     
  Branches     1058     1059       +1     
==========================================
+ Hits         4417     4429      +12     
+ Misses        119      117       -2     
Impacted Files Coverage Δ
packages/publish/src/lib/npm-publish.ts 100.00% <100.00%> (ø)
packages/publish/src/publish-command.ts 99.12% <100.00%> (+0.04%) ⬆️
packages/core/src/utils/pulse-till-done.ts 100.00% <0.00%> (+8.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit acd586d into main Feb 4, 2023
@ghiscoding ghiscoding deleted the feat/recoverable-publish-failures branch February 4, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant