Patch add gitlab support #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AtrisMio hey 👋 thanks for working on this! I'm currently on vacation and will review this properly once I get back. |
|
@Turbo87 thx for that. |
|
@AtrisMio Hey~ It's good ~~ Does this PR support private gitlab |
|
@my9074 Yes, It can use environment of GITLAB_SERVER. GITLAB_SERVER=https://gitlab.my-private-site.com GITLAB_AUTH=xxxxx lerna-changelog |
|
@AtrisMio this seems to be a pretty large refactoring. I'm not sure how to properly review this. Can you break this down into smaller chunks and explain them separately? 🤔 |
|
@Turbo87 thx for reply, I will break this down in the near future. |
|
Any update? |
dbendaou
reviewed
Nov 14, 2019
| this.ignoreCommitters = config.ignoreCommitters; | ||
| this.auth = this.getAuthToken(); | ||
| if (!this.auth) { | ||
| throw new ConfigurationError("Must provide GITHUB_AUTH"); |
There was a problem hiding this comment.
or GITLAB_AUTH if --git-provider=gitlab ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gitlab support and refactor code.