Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade make-fetch-happen to v5.0.0 #142

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Upgrade make-fetch-happen to v5.0.0 #142

merged 1 commit into from
Oct 4, 2019

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Sep 29, 2019

No description provided.

@Turbo87
Copy link
Contributor

Turbo87 commented Sep 29, 2019

I can't find any references to a v5 release at https://github.com/zkat/make-fetch-happen. Do you know what changed between those releases and why it is not part of the repo?

@trivikr
Copy link
Contributor Author

trivikr commented Sep 29, 2019

I've created an issue with the repo at zkat/make-fetch-happen#69

@isaacs
Copy link

isaacs commented Oct 3, 2019

@Turbo87
Copy link
Contributor

Turbo87 commented Oct 3, 2019

thanks @isaacs! looks like the breaking change doesn't affect us.

@trivikr we currently have a merge conflict in the yarn.lock file. can you rebase this PR? I guess we might as well migrate to v6.0.0, which was just released two days ago.

@trivikr trivikr changed the title chore(dep): upgrade make-fetch-happen to ^5.0.0 chore(dep): upgrade make-fetch-happen to ^6.0.0 Oct 3, 2019
@trivikr
Copy link
Contributor Author

trivikr commented Oct 3, 2019

can you rebase this PR? I guess we might as well migrate to v6.0.0, which was just released two days ago.

PR rebased, and upgraded to make-fetch-happen@^6.0.0

@Turbo87
Copy link
Contributor

Turbo87 commented Oct 3, 2019

argh, sorry, their changelog does not mention that Node.js 8 is now required in v6.0.0

@trivikr
Copy link
Contributor Author

trivikr commented Oct 3, 2019

@Turbo87 Can we release lerna-changelog 1.0.0 deprecating Node.js 6.x as suggested in #147 (comment)?

The last 0.x release was in Oct 2018, and a major version bump is due! https://github.com/lerna/lerna-changelog/releases

@Turbo87
Copy link
Contributor

Turbo87 commented Oct 3, 2019

I'm a bit hesitant because Node 8 will be EOL at the end of the year, so we might as well wait until then and then drop Node 8 support as well. 🤔

@trivikr
Copy link
Contributor Author

trivikr commented Oct 3, 2019

I'm a bit hesitant because Node 8 will be EOL at the end of the year, so we might as well wait until then and then drop Node 8 support as well. 🤔

Why not drop Node 8 support in v2.0.0?
This way your clients will have an option to choose whichever version of lerna-changelog they want, based on Node.js version they're using.

@trivikr trivikr changed the title chore(dep): upgrade make-fetch-happen to ^6.0.0 chore(dep): upgrade make-fetch-happen to ^5.0.0 Oct 4, 2019
@trivikr
Copy link
Contributor Author

trivikr commented Oct 4, 2019

forced update to make-fetch-happen@^5.0.0 version as of now

@Turbo87 Turbo87 merged commit 901fb4a into lerna:master Oct 4, 2019
@trivikr trivikr deleted the upgrade-make-fetch-happen branch October 4, 2019 15:03
@Turbo87 Turbo87 changed the title chore(dep): upgrade make-fetch-happen to ^5.0.0 Upgrade make-fetch-happen to v5.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants