Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit commiters line when all are filtered out #296

Merged
merged 2 commits into from
Aug 7, 2021
Merged

Omit commiters line when all are filtered out #296

merged 2 commits into from
Aug 7, 2021

Conversation

petrch87
Copy link

  • do not add line about commiters to markdown when all of the contributers are filtered out in options

@petrch87 petrch87 mentioned this pull request Apr 17, 2020
Open
emmenko
emmenko reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Would you mind maybe adding a test for this?

@Turbo87 Turbo87 added the bug label Aug 7, 2021
Petr Chňoupek and others added 2 commits August 7, 2021 14:55
@Turbo87
Omit commiters line when all are filtered out
6664d32 
- do not add line about commiters to markdown when all of the contributers are filtered out in options
@Turbo87
markdown-renderer: Add contributors list tests
e0d0050
@Turbo87 Turbo87 force-pushed the omit-commiters-line-when-empty branch from 31fab91 to e0d0050 Compare August 7, 2021 12:55
@Turbo87 Turbo87 merged commit 9101663 into lerna:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmenko emmenko emmenko left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petrch87 @emmenko @Turbo87