refactor(symlink-dependencies): Pass Tracker instance instead of this…

….logger
lerna · Dec 31, 2018 · 8957648 · 8957648
1 parent da81e60
commit 8957648
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/commands/bootstrap/index.js b/commands/bootstrap/index.js
@@ -543,7 +543,11 @@ class BootstrapCommand extends Command {
    * @returns {Promise}
    */
   symlinkPackages() {
-    return symlinkDependencies(this.filteredPackages, this.targetGraph, this.logger);
+    return symlinkDependencies(
+      this.filteredPackages,
+      this.targetGraph,
+      this.logger.newItem("bootstrap dependencies")
+    );
   }
 }
 

diff --git a/commands/link/index.js b/commands/link/index.js
@@ -30,7 +30,7 @@ class LinkCommand extends Command {
       return this.convertLinksToFileSpecs();
     }
 
-    return symlinkDependencies(this.allPackages, this.targetGraph, this.logger);
+    return symlinkDependencies(this.allPackages, this.targetGraph, this.logger.newItem("link dependencies"));
   }
 
   convertLinksToFileSpecs() {

diff --git a/utils/symlink-dependencies/symlink-dependencies.js b/utils/symlink-dependencies/symlink-dependencies.js
@@ -17,12 +17,10 @@ module.exports = symlinkDependencies;
  * Symlink package binaries to dependent packages' node_modules/.bin directory
  * @param {Array.<Package>} packages
  * @param {Object} packageGraph
- * @param {Object} logger
+ * @param {Tracker} tracker
  * @returns {Promise}
  */
-function symlinkDependencies(packages, packageGraph, logger) {
-  const tracker = logger.newItem("symlink packages");
-
+function symlinkDependencies(packages, packageGraph, tracker) {
   tracker.info("", "Symlinking packages and binaries");
   tracker.addWork(packages.length);