fix(init): Consume lernaVersion from options, not instance property

lerna · Aug 15, 2018 · 89e31d2 · 89e31d2
1 parent 12b4280
commit 89e31d2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/commands/init/index.js b/commands/init/index.js
@@ -29,6 +29,7 @@ class InitCommand extends Command {
 
   initialize() {
     this.exact = this.options.exact;
+    this.lernaVersion = this.options.lernaVersion;
 
     if (!this.gitInitialized()) {
       this.logger.info("", "Initializing Git repository");

diff --git a/core/command/__tests__/command.test.js b/core/command/__tests__/command.test.js
@@ -57,12 +57,6 @@ describe("core-command", () => {
   // convenience to avoid silly "not implemented errors"
   const testFactory = (argv = {}) => new OkCommand(Object.assign({ cwd: testDir }, argv));
 
-  describe(".lernaVersion", () => {
-    it("should be added to the instance", async () => {
-      expect(testFactory({ lernaVersion: "__TEST__" }).lernaVersion).toBe("__TEST__");
-    });
-  });
-
   describe(".logger", () => {
     it("should be added to the instance", async () => {
       const command = testFactory();

diff --git a/core/command/index.js b/core/command/index.js
@@ -26,10 +26,9 @@ class Command {
     this._argv = argv;
     log.silly("argv", argv);
 
-    this.lernaVersion = argv.lernaVersion;
     if (!argv.composed) {
       // composed commands have already logged the lerna version
-      log.info("version", this.lernaVersion);
+      log.info("version", argv.lernaVersion);
     }
 
     // "FooCommand" => "foo"