chore: update repo to nx 17.3 (#3944)

lerna · Feb 5, 2024 · bd0b5ce · bd0b5ce
1 parent 4fcac71
commit bd0b5ce
Show file tree

Hide file tree

Showing 47 changed files with 571 additions and 521 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -230,5 +230,8 @@ jobs:
 
       - name: Run e2e tests for task-runner
         if: ${{ steps.check_affected.outputs.is_affected }}
-        run: e2e/run/task-runner/src/run-tests.sh
+        run: |
+          # We do not want the automatic Github Actions grouping to be applied to the e2e tests, or the snapshots won't match local
+          unset GITHUB_ACTIONS
+          e2e/run/task-runner/src/run-tests.sh
         shell: bash
diff --git a/e2e/changed/project.json b/e2e/changed/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/changed/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/clean/project.json b/e2e/clean/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/clean/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/create/project.json b/e2e/create/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/create/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/diff/project.json b/e2e/diff/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/diff/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/exec/project.json b/e2e/exec/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/exec/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/info/project.json b/e2e/info/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/info/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/init/project.json b/e2e/init/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/init/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/list/project.json b/e2e/list/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/list/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/publish/project.json b/e2e/publish/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/publish/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/repair/project.json b/e2e/repair/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/repair/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/run/legacy-task-runner/project.json b/e2e/run/legacy-task-runner/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/run/legacy-task-runner/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/run/task-runner/project.json b/e2e/run/task-runner/project.json
@@ -20,10 +20,7 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/run/task-runner/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/version/project.json b/e2e/version/project.json
@@ -9,10 +9,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/version/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/e2e/watch/project.json b/e2e/watch/project.json
@@ -8,10 +8,7 @@
     "run-e2e-tests": {},
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["e2e/watch/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   }
 }
diff --git a/integration/project.json b/integration/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["integration/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "integration": {
       "executor": "@nx/jest:jest",

diff --git a/libs/child-process/project.json b/libs/child-process/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/child-process/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/add/project.json b/libs/commands/add/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/add/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/bootstrap/project.json b/libs/commands/bootstrap/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/bootstrap/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/changed/project.json b/libs/commands/changed/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/changed/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/clean/project.json b/libs/commands/clean/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/clean/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/create/.eslintrc.json b/libs/commands/create/.eslintrc.json
@@ -4,7 +4,10 @@
   "overrides": [
     {
       "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
-      "rules": {}
+      "rules": {
+        "node/no-extraneous-require": "off",
+        "import/no-extraneous-dependencies": "off"
+      }
     },
     {
       "files": ["*.ts", "*.tsx"],

diff --git a/libs/commands/create/project.json b/libs/commands/create/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/create/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     }
   },
   "tags": []

diff --git a/libs/commands/diff/project.json b/libs/commands/diff/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/diff/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/exec/project.json b/libs/commands/exec/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/exec/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/import/project.json b/libs/commands/import/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/import/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/info/project.json b/libs/commands/info/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/info/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/init/project.json b/libs/commands/init/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/init/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/link/project.json b/libs/commands/link/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/link/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/list/project.json b/libs/commands/list/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/list/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/publish/project.json b/libs/commands/publish/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/publish/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/run/project.json b/libs/commands/run/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/run/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",

diff --git a/libs/commands/version/project.json b/libs/commands/version/project.json
@@ -6,10 +6,7 @@
   "targets": {
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["libs/commands/version/**/*.ts"]
-      }
+      "outputs": ["{options.outputFile}"]
     },
     "test": {
       "executor": "@nx/jest:jest",