feat(bootstrap): Short-circuit when local file: specifiers are detect…

…ed in the root

commands/bootstrap/__tests__/__fixtures__/relative-file-specs/.gitignore

@@ -0,0 +1 @@
+node_modules

commands/bootstrap/__tests__/__fixtures__/relative-file-specs/.npmrc

@@ -0,0 +1 @@
+registry = https://registry.npmjs.org/

commands/bootstrap/__tests__/__fixtures__/relative-file-specs/lerna.json

@@ -0,0 +1,3 @@
+{
+  "version": "1.0.0"
+}

commands/bootstrap/__tests__/__fixtures__/relative-file-specs/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "relative-file-specs",
+  "description": "file: specifiers in dependencies should trigger root-only bootstrap",
+  "private": true,
+  "version": "0.0.0-lerna",
+  "dependencies": {
+    "package-2": "file:packages/package-2"
+  }
+}

commands/bootstrap/__tests__/__fixtures__/relative-file-specs/packages/package-1/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "package-1",
+  "version": "1.0.0",
+  "changed": false,
+  "dependencies": {
+    "tiny-tarball": "^1.0.0"
+  }
+}

commands/bootstrap/__tests__/__fixtures__/relative-file-specs/packages/package-2/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "package-2",
+  "version": "1.0.0",
+  "dependencies": {
+    "package-1": "file:../package-1"
+  }
+}

commands/bootstrap/__tests__/bootstrap-command.test.js

@@ -438,6 +438,23 @@ describe("BootstrapCommand", () => {
     });
   });
 
+  describe("with relative file: specifiers in root dependencies", () => {
+    it("only installs in the root", async () => {
+      const testDir = await initFixture("relative-file-specs");
+
+      await lernaBootstrap(testDir)();
+
+      expect(npmInstall.dependencies).not.toBeCalled();
+      expect(npmInstall).lastCalledWith(
+        expect.objectContaining({ name: "relative-file-specs" }),
+        expect.objectContaining({
+          npmClient: "npm",
+          stdio: "inherit",
+        })
+      );
+    });
+  });
+
   describe("with duplicate package names", () => {
     it("throws an error", async () => {
       expect.assertions(1);

commands/bootstrap/index.js

@@ -2,6 +2,7 @@
 
 const dedent = require("dedent");
 const getPort = require("get-port");
+const npa = require("npm-package-arg");
 const path = require("path");
 const pFinally = require("p-finally");
 const pMap = require("p-map");
@@ -86,7 +87,7 @@ class BootstrapCommand extends Command {
   }
 
   execute() {
-    if (this.options.useWorkspaces) {
+    if (this.options.useWorkspaces || this.rootHasLocalFileDependencies()) {
       return this.installRootPackageOnly();
     }
 
@@ -124,6 +125,22 @@ class BootstrapCommand extends Command {
     return npmInstall(this.project.package, this.npmConfig);
   }
 
+  /**
+   * If the root manifest has local dependencies with `file:` specifiers,
+   * all the complicated bootstrap logic should be skipped in favor of
+   * npm5's package-locked auto-hoisting.
+   * @returns {Boolean}
+   */
+  rootHasLocalFileDependencies() {
+    const rootDependencies = Object.assign({}, this.project.package.dependencies);
+
+    return Object.keys(rootDependencies).some(
+      name =>
+        this.packageGraph.has(name) &&
+        npa.resolve(name, rootDependencies[name], this.project.rootPath).type === "directory"
+    );
+  }
+
   runLifecycleInPackages(stage) {
     this.logger.verbose("lifecycle", stage);
 

commands/bootstrap/package.json

@@ -49,6 +49,7 @@
     "dedent": "^0.7.0",
     "get-port": "^3.2.0",
     "multimatch": "^2.1.0",
+    "npm-package-arg": "^6.0.0",
     "npmlog": "^4.1.2",
     "p-finally": "^1.0.0",
     "p-map": "^1.2.0",