Add wrong test

__fixtures__/cycle-parent/graph.txt

@@ -0,0 +1,13 @@
+https://github.com/lerna/lerna/issues/2107#issuecomment-511987691
+
+          +---+
+   /----> | B |
+  |       +---+
+  |
++---+     +---+ <----\
+| A | --> | C |       |
++---+     +---+ <-\   |
+  |                |  |
+  |       +---+ <-/   |
+   \----> | D |       |
+          +---+ <----/

__fixtures__/cycle-parent/lerna.json

@@ -0,0 +1,3 @@
+{
+  "version": "1.0.0"
+}

__fixtures__/cycle-parent/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "babel-bug"
+}

__fixtures__/cycle-parent/packages/a/package.json

@@ -0,0 +1,9 @@
+{
+    "name": "a",
+    "version": "1.0.0",
+    "dependencies": {
+        "b": "^1.0.0",
+        "c": "^1.0.0",
+        "d": "^1.0.0"
+    }
+}

__fixtures__/cycle-parent/packages/b/package.json

@@ -0,0 +1,4 @@
+{
+    "name": "b",
+    "version": "1.0.0"
+}

__fixtures__/cycle-parent/packages/c/package.json

@@ -0,0 +1,7 @@
+{
+    "name": "c",
+    "version": "1.0.0",
+    "dependencies": {
+        "d": "^1.0.0"
+    }
+}

__fixtures__/cycle-parent/packages/d/package.json

@@ -0,0 +1,7 @@
+{
+    "name": "d",
+    "version": "1.0.0",
+    "dependencies": {
+        "c": "^1.0.0"
+    }
+}

__fixtures__/toposort/lerna.json

@@ -1,3 +1,3 @@
 {
-  "version": "1.0.0"
+  "version": "independent"
 }

__fixtures__/toposort/package.json

@@ -1,3 +1,3 @@
 {
-  "name": "independent"
+  "name": "toposort"
 }

commands/version/__tests__/__snapshots__/version-command.test.js.snap

@@ -467,7 +467,7 @@ Array [
 ]
 `;
 
-exports[`VersionCommand versions all transitive dependents after change 1`] = `
+exports[`VersionCommand version ordering versions all transitive dependents after change 1`] = `
 "v2.0.0
 
 HEAD -> master, tag: v2.0.0

commands/version/__tests__/version-command.test.js

@@ -626,20 +626,48 @@ describe("VersionCommand", () => {
     expect(logMessages).toContain("No changed packages to version");
   });
 
-  it("versions all transitive dependents after change", async () => {
-    const testDir = await initFixture("snake-graph");
+  describe("version ordering", () => {
+    it("versions all transitive dependents after change", async () => {
+      const testDir = await initFixture("snake-graph");
 
-    await gitTag(testDir, "v1.0.0");
-    await fs.outputFile(path.join(testDir, "packages/package-1/hello.js"), "world");
-    await gitAdd(testDir, ".");
-    await gitCommit(testDir, "feat: hello");
+      await gitTag(testDir, "v1.0.0");
+      await fs.outputFile(path.join(testDir, "packages/package-1/hello.js"), "world");
+      await gitAdd(testDir, ".");
+      await gitCommit(testDir, "feat: hello");
+
+      collectUpdates.mockImplementationOnce(collectUpdatesActual);
+
+      await lernaVersion(testDir)("major", "--yes");
+
+      const patch = await showCommit(testDir);
+      expect(patch).toMatchSnapshot();
+    });
 
-    collectUpdates.mockImplementationOnce(collectUpdatesActual);
+    it("handles cycles in topological order", async () => {
+      const testDir = await initFixture("cycle-parent");
 
-    await lernaVersion(testDir)("major", "--yes");
+      await gitTag(testDir, "v1.0.0");
 
-    const patch = await showCommit(testDir);
-    expect(patch).toMatchSnapshot();
+      await Promise.all(
+        ["a", "b", "c", "d"].map(n => fs.outputFile(path.join(testDir, "packages", n, "index.js"), "hello"))
+      );
+      await gitAdd(testDir, ".");
+      await gitCommit(testDir, "feat: hello");
+
+      collectUpdates.mockImplementationOnce(collectUpdatesActual);
+
+      await lernaVersion(testDir)("major", "--yes");
+
+      const patch = await showCommit(testDir, "--name-only");
+      expect(patch).toMatchInlineSnapshot(`
+        "v2.0.0
+
+        HEAD -> master, tag: v2.0.0
+
+        lerna.json
+        packages/b/package.json"
+      `);
+    });
   });
 
   describe("with relative file: specifiers", () => {