Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna publish --canary=${my_prerelease_tag} doesn't work #1008

Closed
achingbrain opened this issue Sep 6, 2017 · 1 comment · Fixed by #1020
Closed

lerna publish --canary=${my_prerelease_tag} doesn't work #1008

achingbrain opened this issue Sep 6, 2017 · 1 comment · Fixed by #1020

Comments

@achingbrain
Copy link
Contributor

When I use the publish command like so:

lerna publish --canary=staging

I would expect changed modules to be published with versions similar to:

Changes:
  - my-module: 1.0.0 => 1.0.0-staging.dd3c916f

Instead it tries to use the value passed to the --canary option to work out a range of git commits:

$ lerna publish --yes --canary=staging
lerna info version 2.1.2
lerna info versioning independent
lerna info canary enabled
lerna info Checking for updated packages...
lerna info Comparing with staging^..staging.
lerna ERR! initialize Error: fatal: bad revision 'staging^..staging'

Expected Behavior

The value passed to the canary flag should appear in the published version string.

Current Behavior

The value passed to the canary flag is used as a git commit id which explodes.

Steps to Reproduce (for bugs)

  1. Pass a value to the canary flag

Your Environment

Executable Version
lerna --version 2.1.2
npm --version 5.4.0
yarn --version n/a
node --version 6.9.1
OS Version
NAME VERSION
macOS Sierra 10.12.5
@lock
Copy link

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant