-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for npm ci
to lerna bootstrap
#1324
Comments
I would just skip * Caveat: |
Hmmm maybe I'm missing something about |
Nope, the Compare
|
Perfect I'll give this a shot, thanks! |
When I use this method mainly switching to
This sorta fills in the cracks, but it's throwing a lot of errors. |
the binaries are not located for each file, so scripts are failing
Do you have a specific example? In most cases this is a dev script that should be moved to the root anyway. No leaf devDependencies are installed when relative file specifiers are used in the root.
|
@evocateur My issue with |
Move all the |
@evocateur when I run |
@reggi I need an actual example to debug, I have no (possible) answer other than "works on my repo". Local You also need all of the leaf packages to specify their sibling dependencies as relative |
Is it possible that npm 3 does not symlink |
Correct, this pattern is npm5 only. |
For repos with a large number of entries in |
There are no PRs yet, if that’s what you mean.
… On Mar 22, 2018, at 19:32, Jeremiah Hall ***@***.***> wrote:
For repos with a large number of entries in lerna.json's packages configuration, this approach is complicated. Is there really no desire to make it possible to use npm ci instead of install?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…nged to `npm ci` once this is fixed lerna/lerna#1324 .
* develop: (68 commits) Added support for absolute paths. update develop config Added Error boundary component which should catch all render errors and uncaught throws. Fixes #409 - Faucet link now opens in new window/tab Some style tweaks Commented out the warning header Fix issue where user profile showed all milestones and marked reviewer incorrectly Donations, campaign and DAC required transactions Campaign managers can now accept proposed milestones. Fix eslint issues. Fixed travis by switching back to npm. The install step should be changed to `npm ci` once this is fixed lerna/lerna#1324 . Added required confirmation count Update EditDAC.jsx update bridge addy add beta configuration Add validations for templates Initial changes to views for campaign, Donations Use default quill dropdown fix feathers endpoint in release config donations and roles on profile page ... # Conflicts: # src/index.js # src/services/DonationService.js
I think this can be closed now that #1360 added it? |
@RobertWSaunders Yes, thanks! |
@evocateur Can you think of any reason why running
As you can see, the command being run is |
No, but you can't |
Thanks @evocateur! I had tried without hoisting but taking a second look I was able to get it. Yeah I got rid of |
If you cannot use |
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Npm 5.7 includes a new install command,
npm ci
, that installs dependencies directly by scanning thepackage-lock.json
and foregoes any additional dependency resolution. This can be much much faster than running the usualnpm install
, saving time on build. Lerna should have an option to use this command instead ofnpm install
when runninglerna bootstrap
.Expected Behavior
Able to use
npm ci
on request to install packages withlerna bootstrap
.Current Behavior
Currently
bootstrap
uses only thenpm install
command to install packages.Possible Solution
Add a
--npm-ci
flag or similar to thebootstrap
command that causes it to usenpm ci
instead ofnpm install
when present.Context
In a CI environment, we wish to have builds run as quickly as possible and
npm ci
is faster thannpm install
.The text was updated successfully, but these errors were encountered: